Fix bugs on multi stream and do optimization on quic stream. #732
+96
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanghaemq <[email protected]>
Signed-off-by: wanghaemq <[email protected]>
Signed-off-by: wanghaemq <[email protected]>
…ng a quic stream. Signed-off-by: wanghaemq <[email protected]>
Signed-off-by: wanghaemq <[email protected]>
…tream whiling quic msgs are cached thoughtfully. Signed-off-by: wanghaemq <[email protected]>
Signed-off-by: wanghaemq <[email protected]>
wanghaEMQ
force-pushed
the
wangha/quic_dev2
branch
from
08f5871 to
fae5bf4
Compare
wanghaEMQ
requested review from
JaylinYu,
RanMaoyi,
StargazerWayne and
xinyi-xs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
- Coverage 65.76% 65.74% -0.02%
==========================================
Files 119 119
Lines 35222 35222
==========================================
- Hits 23163 23158 -5
- Misses 12059 12064 +5
☔ View full report in Codecov by Sentry. |
xinyi-xs
approved these changes
Nov 13, 2023
RanMaoyi
approved these changes
Nov 13, 2023
JaylinYu
approved these changes
Nov 16, 2023
| // Iterate topic lmq and send | ||
| size_t lmqsz = nni_lmq_len(s->topic_lmq); | ||
| log_debug("topic_lmq sz%ld Cached msg number%d", lmqsz, (int)(num_ptr - (char *)s)); | ||
| for (int i=0; i<(int)lmqsz && (void *)num_ptr != s; ++i) { |
There was a problem hiding this comment.
Sorry. I forgot to remove it
| @@ -427,7 +427,10 @@ quic_stream_cb(int events, void *arg) | |||
| nni_aio_list_remove(aio); | |||
| QUIC_BUFFER *buf = nni_aio_get_input(aio, 0); | |||
| free(buf); | |||
| nni_aio_finish(aio, 0, nni_aio_count(aio)); | |||
| if (rc != 0) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. after those commits. The multistream feature is more stable. Although it still could crash under benchmark.