Sam gw fix #21
Merged
Sam gw fix #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y before poisson sampling then it needs to be re-converted back to 1/dlogf for proper characteristic strain calculation.
…--- need a full bin (i.e. two edges)
|
This fixes the original issue of inconsistent GW spectra in the high-frequency portion. The issue was that the number of binaries per unit log frequency interval were being drawn from the poisson distribution. Frequency needs to be integrated over, then discretize, then re-divide by log-frequency interval. Note that there is still (or is a new?) problem at lower frequencies, where the kalepy sampled spectrum is systematically higher than the semi-analytic calculation. Reason unclear, to be resolved in a separate PR.
|
This was referenced Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status