Modify wallet_create CLI to allow seed & password change
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sina Mahmoodi <[email protected]>
PlasmaPower
reviewed
Mar 22, 2018
cryptocode
approved these changes
Jan 20, 2019
|
@cryptocode it does make more sense with #1567 |
|
Original PR was modified to allow seed & password set inside of --wallet_create command |
SergiySW
changed the title
wallet_import_seed option to cliwallet_create CLI to allow seed & password change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It creates a new wallet, and changes the seed to the provided
--key.However I couldn't think of a good way to check if a wallet with this seed already exists, since it would require all of their passwords.