Do not add processed live traffic into priorities

[gr0vity-dev]

I noticed that processed live traffic is inserted into priorities.
My understanding is that processed blocks from live traffic don't need further bootstrapping and they should not be a bootstrap priority.

[clemahieu]

I think a full bootstrap profile would give an answer.

[gr0vity-dev]

When the live traffic block is processed (with result == progress). Doesn't this mean that the block was inserted into the ledger and the account chain is fully in sync with the network ?

I'm running a live bootstrap with a modified version, having among others this What should I be looking at ?

[gr0vity-dev-bot]

Test Results for Commit 83563b3

Pull Request 4801: Results
Overall Status: ❌

Test Case Results

• ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 111s)
• ✅ 5n4pr_conf_10k_change: PASS (Duration: 148s)
• ✅ 5n4pr_conf_change_dependant: PASS (Duration: 138s)
• ✅ 5n4pr_conf_change_independant: PASS (Duration: 133s)
• ❌ 5n4pr_conf_send_dependant: FAIL (Duration: 830s)
• Log
• ✅ 5n4pr_conf_send_independant: PASS (Duration: 120s)
• ✅ 5n4pr_rocks_10k_bintree: PASS (Duration: 115s)
• ✅ 5n4pr_rocks_10k_change: PASS (Duration: 146s)

Last updated: 2024-12-03 14:33:25 UTC

[pwojcikdev]

I don't think profiling the from scratch bootstrap is a proper way to judge an impact of this. Rather this should affect how node handles live spam, as this should reduce bootstrap traffic in this case. If spam tests look OK we should merge this.