Automatic database backend #4754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed LMDB test Update nodeconfig.hpp Update nodeconfig.hpp
Test Results for Commit 824922ePull Request 4754: Results Test Case Results
Last updated: 2024-10-17 18:57:16 UTC |
qwahzi
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching database backend between LMDB and RocksDb is currently done by setting
RocksDb.enabledto true or false in the config.This PR removes that setting and adds a new
Database_backendconfig setting.Database_backendcan be set to one of the following:The first two will force the use of the specific backend.
When using auto mode the node will look for an existing ledger and use this. If no ledger is found it will initialize a new
RocksDbLMDB ledger. If multiple ledgers are found it will display a warning message and use the RocksDb ledger.The main purpose is to make new node operators use RocksDb but without forcing existing LMDB users to make changes.
In future node versions (V29?) we can show messages to LMDB users that encourage them to update to RocksDb and instructions on how to do this.
Even later versions (V30?) could halt the node initialization if LMDB is used and display instructions on updating. If they insist on using LMDB they can set
Database_backendto lmdb