Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli support for disable_max_peers... node flags #4620

Merged

Conversation

gr0vity-dev
Copy link
Contributor

@gr0vity-dev gr0vity-dev commented May 14, 2024

I noticed that the following node flags can't be passed from cli and make the node crash on startup :

disable_max_peers_per_ip
disable_max_peers_per_subnetwork
disable_bootstrap_bulk_pull_server
disable_bootstrap_bulk_push_client
disable_tcp_realtime
disable_ongoing_telemetry_requests
disable_block_processor_republishing
force_use_write_queue
disable_search_pending
read_only
disable_connection_cleanup
inactive_node
bootstrap_interval

In this pull request I added support for

  • disable_max_peers_per_ip
  • disable_max_peers_per_subnetwork

because they are useful for local testing

And these:

  • disable_bootstrap_bulk_pull_server
  • disable_bootstrap_bulk_push_client
  • disable_tcp_realtime
  • disable_ongoing_telemetry_requests
  • disable_block_processor_republishing
  • disable_search_pending

@clemahieu clemahieu merged commit 8255d97 into nanocurrency:develop May 19, 2024
25 of 26 checks passed
@qwahzi qwahzi added this to the V27 milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants