Scheduler test cleanup #4619
Merged
Scheduler test cleanup #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is supposed to be testing the node's internal election activation logic but this is being circumvented by activating elections within the test itself.
… directly calling scheduler.
…om rpc.account_representative_set_epoch_2_insufficient_work Comment about slow confirmation seems out of date as there is no performance difference simply checking confirmed status.
…and start elections.
…ections rather than using node::process_active.
pwojcikdev
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a number of unit test cleanups to eliminate directly calling the election scheduler when unrelated to the purpose of the test.