-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats overhaul #4583
Merged
pwojcikdev
merged 26 commits into
nanocurrency:develop
from
pwojcikdev:stats-improvements-2
Apr 30, 2024
Merged
Stats overhaul #4583
pwojcikdev
merged 26 commits into
nanocurrency:develop
from
pwojcikdev:stats-improvements-2
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
stats-improvements-2
branch
from
April 24, 2024 14:51
98be662
to
c6f88b7
Compare
pwojcikdev
force-pushed
the
stats-improvements-2
branch
from
April 24, 2024 19:05
c6f88b7
to
663b98b
Compare
dsiganos
previously approved these changes
Apr 26, 2024
LGTM, I did a high level review only because a detailed review would take too long. |
# Conflicts: # nano/lib/thread_roles.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats overhaul
The goal of this PR is to address some of the issues that have been increasingly cropping up with the current stats system. I believe that having a more flexible and performant system will allow us to experiment and iterate faster.
The immediate problem that is fixed is the fact that we ran out of space for declaring new stat enums:
However, this PR contains a bit more than that. The main changes are:
stat::detail
enum to haveuint8
underlying type. This allows for practically unlimited number of custom stats.Note: I'm still not sure whether this approach is really better, this needs a bit more experimentation.
stat::detail::all
enum. Previously we tracked a specialall
entry that was used to aggregate all stats of a given type. It was used only by unit tests and required special filters to remove from grafana dashboards, where it unnecessarily cluttered the view. Now stat aggregation is handled by a dedicated overload ofstats::count ()
function.Heatmaps
I added experimental support for histogram generation to my fork of the
nano-prom-exporter
(https://github.com/pwojcikdev/nano-prom-exporter/commits/histograms/). This allows for generating heatmaps like this one: