Test daemon interrupt handling #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Apr 14, 2024
|
The windows systests are failing. @RickiNano could you help debug this on windows? |
pwojcikdev
force-pushed
the
daemon-systests-rebased
branch
from
2fa9185 to
828ab46
Compare
|
Given that macOS and Linux work fine, I assume it must be a Windows bug (either in the node or in Windows handling of bash scripts). Please investigate the Windows errors as a separate issue/PR. To avoid stalling this I modified the workflow to ignore systest errors on Windows. |
|
I'll look into the windows error, but as Piotr says there is no need to hold this pr back because of this |
|
I've found a solution for the windows problem. It changes the way we run the tests for Windows so I think it should be in a separate PR so it does not stall this pr |
dsiganos
approved these changes
Apr 17, 2024
|
Issue to track the windows test problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a system test that ensures correct behavior of daemon interrupt handling. Additionally this cleans up and improves output of the whole systest suite.