Improve write_database_queue::wait description and add [[nodiscard]] #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
previously approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Blocks until we are at the head of the queue and blocks other waiters until write_guard goes out of scope
I'm having a bit of trouble understanding why this write_database_queue is needed in the first place, this description sounds like just acquiring a mutex.
clemahieu
force-pushed
the
db_guard_nodiscard
branch
from
2ad38a6 to
1d7976a
Compare
|
Added a better description. The write queue gives fair access to the exclusive database write transaction which is guarded by a mutex with no fairness guarantee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.