Introduce nano-nightly dockerhub registry for live network builds #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2024 13:58
- all non release builds for the live network are pushed to nano-nightly - only release builds will be pushed to nanocurrency/nano dockerhub registry
thsfs
requested changes
Mar 21, 2024
pwojcikdev
approved these changes
Mar 21, 2024
clemahieu
approved these changes
Mar 21, 2024
thsfs
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we create live, beta and test network builds twice a week and each of them is published to docker hub.
On Dockerhub, builds for live network are described as "Nano Production Builds" while it also has non release builds, which may create confusion.
With this pull request, another dockerhub target
nano-nightlyis introducednanocurrency/nano-nightlywill have all non release builds (DBandRCbuilds)nanocurrency/nanowill only have the official release builds.I did the following tests:
DB build (run on
developbranch withrelease_build=='false')Resulting docker tag gr0vity/nano-nightly:V27.0DB11
This is the github runner log
RC build (run on
releases/v27branch withrelease_build=='false')Resulting docker tag gr0vity/nano-nightly:V27.0RC1
This is the github runner log
Release build (run on
releases/v27branch withrelease_build=='true')Resulting docker tag gr0vity/nano:V27.0
This is the github runner log