Introduce ledger confirmed_set/any_set classes to separate confirmed-only and confirmed/unconfirmed operations on the ledger #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed base file class name to ledger_view_base and renamed the user-facing class to ledger_view. |
pwojcikdev
reviewed
Mar 13, 2024
|
Rebased on top of #4484 |
clemahieu
force-pushed
the
ledger_view
branch
10 times, most recently
from
e8059be to
0655adc
Compare
clemahieu
force-pushed
the
ledger_view
branch
7 times, most recently
from
55ac5d9 to
3d681c6
Compare
|
I reworked this from the previous ledger_view design for several reasons:
|
clemahieu
changed the title
clemahieu
force-pushed
the
ledger_view
branch
3 times, most recently
from
0143f27 to
ebe67dd
Compare
clemahieu
force-pushed
the
ledger_view
branch
2 times, most recently
from
82d480c to
69c7913
Compare
clemahieu
changed the title
clemahieu
force-pushed
the
ledger_view
branch
4 times, most recently
from
f7b83ad to
c192843
Compare
dsiganos
reviewed
Apr 26, 2024
| return block_balance > previous_balance.value () ? block_balance.number () - previous_balance.value ().number () : previous_balance.value ().number () - block_balance.number (); | ||
| } | ||
|
|
||
| // Balance for account containing hash |
There was a problem hiding this comment.
This comment seems wrong, it can be removed since the name of the function is now obvious.
|
|
||
| std::optional<nano::amount> nano::ledger_set_any::account_balance (secure::transaction const & transaction, nano::account const & account_a) const | ||
| { | ||
| auto block = block_get (transaction, ledger.any.account_head (transaction, account_a)); |
There was a problem hiding this comment.
ledger.any seems redundant
dsiganos
reviewed
Apr 27, 2024
|
|
||
| public: // Operations on pending entries | ||
| std::optional<nano::pending_info> pending_get (secure::transaction const & transaction, nano::pending_key const & key) const; | ||
| bool receivable_any (secure::transaction const & transaction, nano::account const & account) const; |
…exists in the confirmed ledger set.
…et height(account) overload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is in preparation for bounded backlog changes. Currently, both confirmed and unconfirmed transactions are together on disk and the ACID properties of the ledger are encapsulated with a database transaction.
With the bounded backlog, blocks will be stored in memory so there will need to be memory synchronization in addition to database synchronization. Rather than filling the ledger class with unconfirmed/confirmed variants for each operation.
The ledger is divided in to several sets and subsets:
ledger::confirmed - The set of confirmed transactions
ledger::any - The superset of confirmed and unconfirmed transactions
When unconfirmed blocks are held in memory the set ledger::unconfirmed will be added which holds only unconfirmed transactions.
In the future the confirming_set can be moved on to ledger which is the subset of unconfirmed blocks that are queued to be moved in to the confirmed set.