Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some helpful comments about unit test socket_timeout.connect #4389

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Some helpful comments about unit test socket_timeout.connect #4389

merged 1 commit into from
Jan 25, 2024

Conversation

dsiganos
Copy link
Contributor

No description provided.

@dsiganos dsiganos added unit test Related to a new, changed or fixed unit test exclude from changelog Indicates the change is not relevant for appearing in the release changelog labels Jan 23, 2024
@dsiganos dsiganos assigned clemahieu and pwojcikdev and unassigned clemahieu and pwojcikdev Jan 23, 2024
@dsiganos dsiganos merged commit 6f996b2 into nanocurrency:develop Jan 25, 2024
18 of 19 checks passed
@dsiganos dsiganos deleted the comment_about_socket_timeout_connect branch January 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@pwojcikdev pwojcikdev Awaiting requested review from pwojcikdev

Assignees
No one assigned
Labels
exclude from changelog Indicates the change is not relevant for appearing in the release changelog unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsiganos @clemahieu @pwojcikdev