Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert boost::filesystem references to std::filesystem #4183

Closed

Conversation

mariomoliner
Copy link
Contributor

associated issue #4057

Copy link
Contributor

@clemahieu clemahieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a formatting run ci/clang-format-do.sh

@@ -4,7 +4,7 @@ target_link_libraries(
nano_rpc
rpc
secure
Boost::filesystem
std::filesystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed.

@@ -0,0 +1,41 @@
#pragma once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some other files got mixed in.

@qwahzi
Copy link
Collaborator

qwahzi commented Oct 19, 2023

Closed by #4057 and #4315

@qwahzi qwahzi closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants