Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow for Valgrind #4050

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Jan 14, 2023

This workflow is set to run for every created tag that starts with V. So, it is intended to generate reports for the automatic beta builds and also for release candidates and official releases.

This is set up to run upon core_test and rpc_test on self-hosted runners by default, as these tests are heavy and require higher use of CPU. It is also possible to trigger it to run manually.

The self-hosted label for it is self-hosted-standard that is intended to run on machines that won't be used for benchmarks.

@thsfs thsfs requested review from clemahieu and dsiganos January 14, 2023 02:49
@thsfs thsfs added this to the V25.0 milestone Jan 14, 2023
@thsfs thsfs added ci/cd exclude from changelog Indicates the change is not relevant for appearing in the release changelog labels Jan 14, 2023
@thsfs
Copy link
Contributor Author

thsfs commented Jan 14, 2023

Will mark this as ready for review when the runner setup is finished.

@thsfs thsfs marked this pull request as ready for review January 16, 2023 17:36
@dsiganos
Copy link
Contributor

This PR depends on this other PR on another repo:
"Add a workflow to automatic respawn the GH self-hosted runners"
https://github.com/nanocurrency/infrastructure/pull/102

However, that other PR needs reworking in my opinion.
And ideally, this workflow will not depend on a workflow of another repo.

@thsfs thsfs removed this from the V25.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd exclude from changelog Indicates the change is not relevant for appearing in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants