Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all unnecessary usings #4049

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Removed all unnecessary usings #4049

merged 1 commit into from
Jan 13, 2023

Conversation

RickiNano
Copy link
Contributor

Removed unnecessary usings from the node project.
Compiled and tested manually.
Unit tests completed successfully

@dsiganos
Copy link
Contributor

Did you use an automated process to remove them?

@RickiNano
Copy link
Contributor Author

@dsiganos
Yes. I used the c++ resharper plugin for Visual Studio

@dsiganos
Copy link
Contributor

Do you know how it decides if an include is needed or not?
How does it deal with #ifdefs?

@clemahieu clemahieu merged commit 5511ec2 into nanocurrency:develop Jan 13, 2023
@RickiNano
Copy link
Contributor Author

I don't know how it checks if a using is needed but it seems to have done a good job

@RickiNano RickiNano deleted the clean-up-includes branch January 13, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants