Add EXPECT_TIMELY test macro
#3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Being the last checks makes them the same as ASSERT_TIMELY, doesn't it? |
dsiganos
previously approved these changes
Sep 1, 2022
thsfs
previously approved these changes
Sep 1, 2022
pwojcikdev
force-pushed
the
prs/expect-timely-macro
branch
from
0229552 to
dacdaab
Compare
dsiganos
reviewed
Sep 2, 2022
nano/test_common/testutil.hpp
Outdated
| { \ | ||
| ASSERT_NO_ERROR (system.poll ()); \ | ||
| } | ||
| #define ASSERT_TIMELY(time, condition) \ |
There was a problem hiding this comment.
The problem with this is that it checks the condition twice. It should only check it once per loop.
For example, it won't catch this condition:
bool counter_increment_and_equals_ten()
{
static int i = 0;
return (--i) == 10;
}
There was a problem hiding this comment.
Right, that was not the best solution. I decided to leave ASSERT TIMELY as is
pwojcikdev
force-pushed
the
prs/expect-timely-macro
branch
from
dacdaab to
a1cddb9
Compare
dsiganos
reviewed
Sep 3, 2022
nano/test_common/testutil.hpp
Outdated
| /** Extends gtest with a std::error_code assert that expects an error */ | ||
| #define ASSERT_IS_ERROR(condition) \ | ||
| GTEST_TEST_ERROR_CODE ((condition.value () > 0), #condition, "An error was expected", "", \ | ||
| GTEST_FATAL_FAILURE_) | ||
|
|
||
| /** Extends gtest with a std::error_code assert that expects an error */ | ||
| #define EXPECT_IS_ERROR(condition) \ | ||
| GTEST_TEST_ERROR_CODE ((condition.value () > 0), #condition, "An error was expected", "", \ |
There was a problem hiding this comment.
condition.value () != 0
protects against signed vs unsigned problems.
condition.value () > 0
dsiganos
reviewed
Sep 3, 2022
nano/test_common/testutil.hpp
Outdated
| #define EXPECT_NO_ERROR(condition) \ | ||
| GTEST_TEST_ERROR_CODE (!(condition), #condition, condition.message ().c_str (), "", \ | ||
| GTEST_NONFATAL_FAILURE_) | ||
|
|
||
| /** Extends gtest with a std::error_code assert that expects an error */ | ||
| #define ASSERT_IS_ERROR(condition) \ |
pwojcikdev
force-pushed
the
prs/expect-timely-macro
branch
from
7b4bc1b to
15b5330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not always possible to call ASSERT_TIMELY, for example from helper functions or lambdas.