Disable systest set_bandwidth_params #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know much about system tests, but perhaps a more universal and more intuitive approach to disabling tests will be prefixing/postfixing their name with "DISABLED_" just like it works in gtest? After some time it might be difficult to understand why one of them is not running unless someone looks at RUNALL implementation |
It fails fairly frequently with error "Address already in use" and I do not what the cause is. It is not a priority and it is not important test, so I am disabling it so we can start getting clean runs through CI and problems do not go unnoticed.
dsiganos
force-pushed
the
disable_systest_set_bandwidth_params
branch
from
e50b418 to
9997492
Compare
|
OK, I renamed the file to end in .disabled. |
pwojcikdev
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails fairly frequently with error "Address already in use" and I do
not what the cause is. It is not a priority and it is not important test,
so I am disabling it so we can start getting clean runs through CI and
problems do not go unnoticed.