Move test code into namespace nano::test #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
reviewed
Aug 10, 2022
pwojcikdev
previously approved these changes
Aug 10, 2022
dsiganos
force-pushed
the
move_functions_nano_test_namespace
branch
from
52f5c64 to
1ccb608
Compare
pwojcikdev
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test code is under namespace nano, some is in nano::test and some is in nano::util.
There seems to be no apparent for this discrepancy, which makes it untidy.
Moving all test code inside the folder test_common into namespace nano::test to make it tidy.