Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db backend namespaces #3784

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Add db backend namespaces #3784

merged 2 commits into from
Apr 9, 2022

Conversation

clemahieu
Copy link
Contributor

This change forces classes under the nano namespace to use a global scope when referencing rocksdb library functions. This allows rocksdb to be used as a namespace under the nano namespace.

…he rocksdb library to use a globally scoped qualified name. This allows rocksdb to be used as a namespace within nano.
@clemahieu clemahieu requested a review from thsfs April 9, 2022 17:26
Copy link
Contributor

@thsfs thsfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

@zhyatt zhyatt added this to the V24.0 milestone Apr 9, 2022
@clemahieu clemahieu merged commit 596e9a2 into develop Apr 9, 2022
@clemahieu clemahieu deleted the db_backend_namespaces branch April 9, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants