Fixing slow_test store.pruned_load. #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re->pruned.del as hashes was empty and querying for .begin (). hashes was never populated even when this test was originally added.
dsiganos
reviewed
Jan 11, 2022
| } | ||
| } | ||
| if (!nano::rocksdb_config::using_rocksdb_in_tests ()) | ||
| { | ||
| auto transaction (store->tx_begin_write ()); | ||
| for (auto k (0); k < batch_size / 2; ++k) | ||
| for (auto k (0); !hashes.empty () && k < batch_size / 2; ++k) |
There was a problem hiding this comment.
Do we need the check !hashes.empty ()?
This is a unit test, if anything is wrong, we want to fail loud and clear rather than handle it quietly.
So I would say that we should ASSERT that hashes is not empty.
dsiganos
previously approved these changes
Jan 12, 2022
…databases (#3666) Previously, it did one thing for lmdb and another for rocksdb due to rocksdb not having an accurate count of blocks. The block counting is now done manually by iterating through all the blocks.
dsiganos
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was crashing on the line store->pruned.del as hashes was empty and querying for .begin (). hashes was never populated even when this test was originally added.