Update confirmation_info RPC call to include representatives final votes for monitoring purposes #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently need a system/permanent error concept in server_socket and we may never need it. We can introduce it if we ever need it.
I don't see how connection aborted is a temporary error. Connection aborted is a permanent state.
We never want to stop listening for incming sockets
…tes for monitoring purposes
|
Tried changing the base to develop as its unlikely to ship for V23 now as the DB5 release seems to resolve the underlying issue and this is just an RPC improvement. This has meant a number of unrelated commits which have been merged into releases/v23 have been included. Will the v23 be merged back into develop upon release? If so I will leave PR as it is is, if not I can cherrypick my 2 commits and recreate. |
MajorChump
force-pushed
the
final-votes-json-rpc
branch
from
102ed40 to
bd2edba
Compare
…tes for monitoring purposes
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're attempting to debug the slow cementing on the long chain on beta, at the moment its not possible to determine whether a vote received from a specific representative is final or not. We're seeing quite a few elections will total > quorum but final < quorum this may help debugging the issue.