Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing nano::ledger_constants in to nano::ledger #3402

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Passing nano::ledger_constants in to nano::ledger #3402

merged 1 commit into from
Jul 27, 2021

Conversation

clemahieu
Copy link
Contributor

Passing nano::ledger_constants in to nano::ledger rather than it being statically initialized. Further work in the effort to reduce static initialization.

theohax
theohax approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@theohax theohax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clemahieu clemahieu merged commit e3563a9 into develop Jul 27, 2021
@clemahieu clemahieu deleted the ledger_constants branch July 27, 2021 09:06
@zhyatt zhyatt added this to the V23.0 milestone Jul 27, 2021
@zhyatt zhyatt added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theohax theohax theohax approved these changes

Assignees
No one assigned
Labels
non-functional change quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clemahieu @theohax @zhyatt