Cleanup of genesis constants within ledger_constants #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… what needed by callers.
… than being memorized unnecessarily.
…g unneeded memorization.
…ation code was using ledger_constants anyway, opt to get the block itself from here rather than passing in a genesis object.
argakiig
approved these changes
Jul 20, 2021
dsiganos
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genesis_block is converted to a block shared_ptr rather than the textual data which callers don't need and could regenerate from the block format.
Replace member variables genesis_hash and genesis_account with same-named functions that derive their values from the genesis block eliminating some memorization.
Remove the nano::genesis parameter from block_store::initialize as most of the body of the function uses the network_params.ledger_constants member to obtain genesis constants anyway.