Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledger_walker.genesis_account_longer unit test on macOS #3374

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

theohax
Copy link
Contributor

@theohax theohax commented Jul 8, 2021

Honestly the test expectation (that was oddly failing on osx_test CI step) isn't something truly needed nor relevant.

But apparently libc++ and libstdc++ have different strategies for hashing policies when the hashmap is empty.

This should fix it.

@theohax theohax requested review from dsiganos and thsfs July 8, 2021 13:46
@theohax theohax merged commit f01616b into develop Jul 8, 2021
@theohax theohax deleted the fix-osx-unit-test-ledger-walker branch July 8, 2021 16:41
@zhyatt zhyatt added the unit test Related to a new, changed or fixed unit test label Jul 8, 2021
@zhyatt zhyatt added this to the V23.0 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants