Don't reference get_available_port from within the node lib. #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…likely shouldn't just for the purpose of getting a dummy port for command line options. This change uses test port 24000 for nano::inactive_node which is used for CLI options and won't collide with live or debug ports.
thsfs
approved these changes
Jun 14, 2021
zhyatt
added
non-functional change
unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the node lib doesn't reference the test_common library and likely shouldn't just for the purpose of getting a dummy port for command-line options. This change uses test port 24000 for nano::inactive_node which is used for CLI options and won't collide with live or debug ports.