Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase soft limit for number of open file descriptors #3304

Merged
merged 3 commits into from
May 27, 2021
Merged

Increase soft limit for number of open file descriptors #3304

merged 3 commits into from
May 27, 2021

Conversation

theohax
Copy link
Contributor

@theohax theohax commented May 25, 2021

No description provided.

@theohax theohax requested review from clemahieu and dsiganos May 25, 2021 13:07
@SergiySW
Copy link
Contributor

SergiySW commented May 25, 2021 •
edited
Loading

I wonder if we can use/modify already existing code. Or at least create new function in the same place for consistency

nano-node/nano/nano_node/daemon.cpp

Line 74 in 9a9168f

size_t fd_limit = nano::get_filedescriptor_limit ();

nano-node/nano/lib/utility.cpp

Line 38 in f7f83e7

std::size_t nano::get_filedescriptor_limit ()

@theohax
Copy link
Contributor Author

theohax commented May 25, 2021

get_filedescriptor_limit

Oh...sure, let me have a look. I hadn't noticed it.

@theohax theohax requested a review from SergiySW May 25, 2021 13:33
@theohax
Copy link
Contributor Author

theohax commented May 25, 2021

@SergiySW addressed, thanks.

@clemahieu clemahieu merged commit 1df238f into develop May 27, 2021
clemahieu added a commit that referenced this pull request May 28, 2021
@clemahieu
Merge pull request #3304 from nanocurrency/file-descriptors-limits
03debef 
Increase soft limit for number of open file descriptors
@clemahieu clemahieu added this to the V22.1 milestone Jun 3, 2021
@zhyatt zhyatt added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jul 16, 2021
@zhyatt zhyatt deleted the file-descriptors-limits branch September 21, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@dsiganos dsiganos Awaiting requested review from dsiganos

@SergiySW SergiySW Awaiting requested review from SergiySW

Assignees
No one assigned
Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V22.1
Development

Successfully merging this pull request may close these issues.
4 participants
@theohax @SergiySW @clemahieu @zhyatt