Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build info shows following description: \ #3144

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

skynxt
Copy link
Contributor

@skynxt skynxt commented Mar 15, 2021

Build Info: 5160073 "GNU C++ version " "5.4.0 20160609" "BOOST 107000" BUILT "Sep 3 2020"
This file has default set to boostVersion=1.69 which is inconsitent with above build info which shows 1.70. Hence, updating default to latest Boost version to 1.75

Build Info: 5160073 "GNU C++ version " "5.4.0 20160609" "BOOST 107000" BUILT "Sep  3 2020" \
This file has default set to boostVersion=1.69 which is inconsitent with above build info which shows 1.70. Hence, updating default to latest Boost version to 1.75
@cryptocode
Copy link
Contributor

@skynxt Very nice. Could you use this opportunity to also remove 1.69 as an option in case "${boostVersion}" as it's no longer a supported version?

@skynxt
Copy link
Contributor Author

skynxt commented Mar 15, 2021

@cryptocode thanks for comment.
Yep, can do that, but had couple of points to discuss.
The following files(for osx, windows) has a reference to 1.70V Boost, is this a binary hosted in cloud? Perhaps version needs to change to the latest 1.75V Boost? nano-node is being successfully being built with 1.75V Boost. If yes, how can this be changed?
https://github.com/nanocurrency/nano-node/blob/develop/util/build_prep/fetch_boost.sh
https://github.com/nanocurrency/nano-node/blob/develop/ci/actions/windows/install_deps.ps1

Also, this minimum requirement need to be changed to 1.75v Boost too in the following link, or just leave as is?
https://docs.nano.org/integration-guides/build-options/#general-build-instructions

Looking forward to your comments.

@cryptocode
Copy link
Contributor

@skynxt we probably want 1.70 as the minimum, see nanocurrency/nano-docs#485 about your last point.

@zhyatt zhyatt requested a review from argakiig March 15, 2021 17:48
@zhyatt zhyatt added this to the V22.0 milestone Mar 15, 2021
@clemahieu clemahieu merged commit 0a9c28e into nanocurrency:develop Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants