Update online weight before checking quorum #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyatt
added
the
quality improvements
SergiySW
previously approved these changes
Nov 13, 2020
clemahieu
previously approved these changes
Nov 18, 2020
SergiySW
previously approved these changes
Dec 11, 2020
clemahieu
previously approved these changes
Dec 12, 2020
argakiig
pushed a commit
that referenced
this pull request
Dec 18, 2020
…m/wezrule/raiblocks into update_online_weight_before_tally
SergiySW
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a large offline rep suddenly comes online the online weight is not updated until after the vote and tally checks have been done (thanks @guilhermelawless for the explanation). We don't know if a vote is a replay until voting on the election. What this PR does is adjust the online weight before such checks (if the vote is not a replay). To prevent the
channelneeding to be passed intoactive_transactions::votethe check to see if the rep is online is done before and boolean is passed in to reflect that.I also came across some small precision issue with the calculation of the delta, this now uses a
nano::uint256and does the multiplication before division to get minimum required quorum.