Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github container repo #3034

Merged
merged 1 commit into from
Nov 3, 2020
Merged

github container repo #3034

merged 1 commit into from
Nov 3, 2020

Conversation

argakiig
Copy link
Contributor

@argakiig argakiig commented Nov 3, 2020 •
edited
Loading

changes made to account for https://docs.docker.com/docker-hub/download-rate-limit/
using ghcr.io
update dockerfiles to include required label for github container repo reference(for ghcr.io)
image built tagged with docker.pkg.github.com and docker hub variants
pull artifacts in ci from ghcr.io instead of docker hub
push to ghcr.io using module for login in and push
continue to deploy to docker hub when password is present

When merged into develop new PRs will pull from ghcr.io for build environment

@argakiig argakiig added universe This item indicates the need for or supplies changes caused by external factors docker updates and changes to the docker build image labels Nov 3, 2020
@argakiig argakiig added this to the V22.0 milestone Nov 3, 2020
@argakiig argakiig requested review from wezrule and zhyatt November 3, 2020 17:35
@argakiig argakiig self-assigned this Nov 3, 2020
github container repo
cdf7f73 
update dockerfiles to include required label for github container repo reference
tags are generated for both locations using build-docker-image
push to ghcr.io using module for login in and push
zhyatt
zhyatt approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@zhyatt zhyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the best with these pieces, but nothing stood out as an issue to me in a brief review of the changes.

@argakiig argakiig merged commit abba607 into nanocurrency:develop Nov 3, 2020
@argakiig argakiig deleted the github_container_repo branch November 3, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyatt zhyatt zhyatt approved these changes

@wezrule wezrule Awaiting requested review from wezrule

Assignees

@argakiig argakiig

Labels
docker updates and changes to the docker build image universe This item indicates the need for or supplies changes caused by external factors
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@argakiig @zhyatt