Remove telemetry signature partitions #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergiySW
previously approved these changes
Oct 23, 2020
zhyatt
added
functionality quality improvements
clemahieu
previously approved these changes
Nov 3, 2020
SergiySW
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently v21 nodes will only understand telemetry if any new data is signed separately, this is not very efficient. This is replacing it by ignoring excess data by still signing the whole payload. No new data will be introduced in v22, and v23 the plan is to drop v21 as they will not understand v2 state blocks. So this will allow v22 to be backwards compatible with any telemetry updates mad in v23.
I've tested this on beta by manually spitting out extra data and all other nodes banned me (as expected) due to the signature not validating, and the other node I had running this PR didn't ban it, just ignored the data.