[RocksDB] Modify some table/column family settings #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
changed the title
wezrule
force-pushed
the
rocksdb_plaintable_unchecked
branch
from
831709d to
3eb9b59
Compare
argakiig
previously approved these changes
Sep 21, 2020
guilhermelawless
added
database
guilhermelawless
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering pending table number of sst files to 2 in level 0 (same as unchecked) as it can also have large number of deletes.
Adding
memtable_whole_key_filtering, and some other settings to improve unchecked_get performance when there is a lot of deletions. Increasingmemtable_prefix_bloom_size_ratio.Tried
max_subcompactionswith io_threads/2, didn't see improvement in performance.Noticed
unchecked_cleanupwas failing with earlier changes and wanted to disable theongoing_unchecked_cleanupas it was interfering with the test.