Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower request loop min_sleep for tests #2905

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Lower request loop min_sleep for tests #2905

merged 1 commit into from
Sep 2, 2020

Conversation

guilhermelawless
Copy link
Contributor

Missed in #2900 as all tests are passing, but on closer inspection the ones making use of the request loop are slower.

Before:

[ RUN      ] active_transactions.confirm_active
[       OK ] active_transactions.confirm_active (1139 ms)
[ RUN      ] active_transactions.confirm_frontier
[       OK ] active_transactions.confirm_frontier (1062 ms)
[ RUN      ] active_transactions.keep_local
[       OK ] active_transactions.keep_local (2257 ms)

After:

[ RUN      ] active_transactions.confirm_active
[       OK ] active_transactions.confirm_active (555 ms)
[ RUN      ] active_transactions.confirm_frontier
[       OK ] active_transactions.confirm_frontier (442 ms)
[ RUN      ] active_transactions.keep_local
[       OK ] active_transactions.keep_local (598 ms)

@guilhermelawless guilhermelawless added the unit test Related to a new, changed or fixed unit test label Sep 2, 2020
@guilhermelawless guilhermelawless added this to the V21.2 milestone Sep 2, 2020
@guilhermelawless guilhermelawless self-assigned this Sep 2, 2020
@guilhermelawless guilhermelawless merged commit 17d013a into nanocurrency:develop Sep 2, 2020
guilhermelawless added a commit that referenced this pull request Sep 2, 2020
@guilhermelawless
Lower request loop min_sleep for tests (#2905)
b86abda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@clemahieu clemahieu clemahieu approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
V21.2
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @clemahieu @SergiySW