Make logging election tally an optional config #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One config for logging on expired elections, another for confirmed elections with multiple blocks, both default to false.
SergiySW
previously approved these changes
Aug 19, 2020
clemahieu
reviewed
Aug 25, 2020
SergiySW
approved these changes
Aug 25, 2020
wezrule
approved these changes
Aug 25, 2020
guilhermelawless
added a commit
that referenced
this pull request
Sep 2, 2020
Adapted for V21.2 patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One config for logging on expired elections, another for confirmed elections with multiple blocks, both default to false.
Since these are similar in output, added a prefix "Election expired" to differentiate them, e.g.: