Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Cxx17 #2878

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Enforce Cxx17 #2878

merged 5 commits into from
Aug 12, 2020

Conversation

argakiig
Copy link
Contributor

@argakiig argakiig commented Aug 11, 2020 •
edited
Loading

move clang test to use clang-6 as it supports all C++17 features
various updates to centos7 build environment for C++17 features
Disable unstable test on *nix using clang when cmake -DCI=1...

@argakiig argakiig added universe This item indicates the need for or supplies changes caused by external factors unit test Related to a new, changed or fixed unit test docker updates and changes to the docker build image labels Aug 11, 2020
@argakiig argakiig added this to the V22.0 milestone Aug 11, 2020
@argakiig argakiig self-assigned this Aug 11, 2020
@argakiig argakiig changed the title Move clang test environment to clang-6 for c++17 support Enforce Cxx17 Aug 11, 2020
@guilhermelawless guilhermelawless added the documentation This item indicates the need for or supplies updated or expanded documentation label Aug 12, 2020
@guilhermelawless guilhermelawless mentioned this pull request Aug 12, 2020
Closed
@guilhermelawless guilhermelawless merged commit 49cb67f into nanocurrency:develop Aug 12, 2020
@argakiig argakiig added the breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. label Aug 12, 2020
@argakiig argakiig deleted the use_clang_6 branch September 14, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermelawless guilhermelawless guilhermelawless approved these changes

@wezrule wezrule wezrule approved these changes

Assignees

@argakiig argakiig

Labels
breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. docker updates and changes to the docker build image documentation This item indicates the need for or supplies updated or expanded documentation unit test Related to a new, changed or fixed unit test universe This item indicates the need for or supplies changes caused by external factors
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@argakiig @wezrule @guilhermelawless