Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different log when the OpenCL library cannot be loaded #2840

Conversation

guilhermelawless
Copy link
Contributor

Currently the only message is "0 platforms" which is misleading.

Not sure about the method used to do this due to the separation we have between the API wrapper by platform, open to suggestions.

Best reviewed without whitespace diffs.

Currently the only message is "0 platforms" which is misleading.
@guilhermelawless guilhermelawless added this to the V22.0 milestone Jul 10, 2020
@guilhermelawless guilhermelawless self-assigned this Jul 10, 2020
@guilhermelawless guilhermelawless force-pushed the opencl/library-load-fail branch from 25209c1 to 4d8ce1c Compare July 10, 2020 18:01
@guilhermelawless guilhermelawless force-pushed the opencl/library-load-fail branch from 2eae90c to c8aff8c Compare July 13, 2020 12:15
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when the library isn't found, but I think it would be nice to another another message if the library is found but there are no compatible platforms/devices.

@guilhermelawless guilhermelawless merged commit 3fd6754 into nanocurrency:develop Jul 15, 2020
@guilhermelawless guilhermelawless deleted the opencl/library-load-fail branch July 15, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants