Using post-processing events for all operations #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
the
performance
SergiySW
previously approved these changes
Jun 29, 2020
wezrule
previously approved these changes
Jul 17, 2020
SergiySW
previously approved these changes
Jul 21, 2020
guilhermelawless
force-pushed
the
blockprocessor/post-events-full
branch
from
0787971 to
0bb7e86
Compare
guilhermelawless
force-pushed
the
blockprocessor/post-events-full
branch
from
1745f4a to
0f55da5
Compare
SergiySW
previously approved these changes
Sep 11, 2020
wezrule
previously approved these changes
Sep 18, 2020
…ost-events-full # Conflicts: # nano/node/node.cpp # nano/node/node.hpp
guilhermelawless
dismissed stale reviews from ghost
, wezrule, and SergiySW
via
566936d
SergiySW
previously approved these changes
Sep 30, 2020
wezrule
previously approved these changes
Oct 7, 2020
guilhermelawless
dismissed stale reviews from wezrule and SergiySW
via
b91f072
wezrule
previously approved these changes
Oct 12, 2020
wezrule
approved these changes
Oct 14, 2020
SergiySW
approved these changes
Oct 14, 2020
# Conflicts: # nano/node/blockprocessor.cpp # nano/node/blockprocessor.hpp # nano/node/node.cpp
clemahieu
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further eliminates cases of simultaneously holding both a write transaction and the active mutex.
std::shared_ptr<nano::block> const &in all blockprocessor and node signaturesupdatedas another type of processing step ofblockprocessor::process_batch, which only updates blocks if they exist. This is used byactive_transactions::restart. Happy to discuss alternative approaches to reduce the complexity ofprocess_batchwhich now differentiates between block/forced/update.