Use ASSERT_TIMELY in tests where possible #2780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASSERT_TIMELY
provides a more concise syntactic way to express:as
ASSERT_TIMELY (10s, condition);
This cannot be used in more complex examples such as when there are other contents of the body. For that we do have
system::poll_until_true
, but that has not been used here.Also modified some places which used a read db transaction variable in each iteration inside the loop body and doing a comparison there. This can be changed to create a temporary transaction as an argument, allowing the use of ASSERT_TIMELY with it.