Cache account count #2511
Merged
Cache account count #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
performance
guilhermelawless
previously approved these changes
Jan 24, 2020
guilhermelawless
approved these changes
Jan 24, 2020
argakiig
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for 2 areas: node telemetry as it is one of the metrics and the only one currently requiring a DB call to retrieve. Also helps RocksDB because it had to cache this value in the DB for fast retrieval. Even better is that we are already iterating over all accounts during start-up for rep_weights so it has negligible start-up cost too.
Tested over a half hour run on live, seemed ok. Note if testing is that the values may seem out of sync (accounts_count RPC & --debug_account_count CLI command), but this is because the write transaction can be held for a long time before committing while the cache is updated real-time.