Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust request aggregator stats #2507

Merged
merged 4 commits into from
Jan 25, 2020
Merged

Adjust request aggregator stats #2507

merged 4 commits into from
Jan 25, 2020

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented Jan 22, 2020 •
edited
Loading

And ensures unique hashes before generating votes, by doing the same sort+unique as for votes.

Based on feedback from @Srayman , these adjusted stats are now useful to determine the ratio of votes-to-hashes and other interesting stats.

aggregator_accepted
aggregator_dropped

requests_cached_hashes
requests_generated_hashes
requests_cached_votes
requests_generated_votes
requests_unknow

@guilhermelawless guilhermelawless added documentation This item indicates the need for or supplies updated or expanded documentation functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality labels Jan 22, 2020
@guilhermelawless guilhermelawless added this to the V21.0 milestone Jan 22, 2020
@guilhermelawless guilhermelawless self-assigned this Jan 22, 2020
@guilhermelawless
Adjust request aggregator stats
4d7fc6c 
And ensure unique hashes before generating votes
@guilhermelawless guilhermelawless mentioned this pull request Jan 25, 2020
Merged
@guilhermelawless guilhermelawless merged commit d1f04a3 into nanocurrency:develop Jan 25, 2020
@guilhermelawless guilhermelawless deleted the aggregator/adjust-stats branch January 25, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@wezrule wezrule wezrule approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
documentation This item indicates the need for or supplies updated or expanded documentation functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @wezrule @SergiySW