Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote replay in crawler #2497

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Vote replay in crawler #2497

merged 3 commits into from
Jan 25, 2020

Conversation

clemahieu
Copy link
Contributor

This change moves the responsibility for informing reps of very-behind sequence numbers off of the vote processor an on to the rep crawler.

  • Moves infrequently used codepath out of hot code section
  • Removes database transactions from vote processor entirely.
  • Eliminate unneeded deque construction of validated votes.

@clemahieu
Move vote replay code in to rep_crawler since this is a very infreque…
e7a17c6 
…ntly needed codepath and it only really needs to be done once and can be done during rep discovery.
@clemahieu
Directly calling vote_blocking instead of creating a new deque of val…
48aef31 
…id votes.
@guilhermelawless guilhermelawless added performance Performance/resource utilization improvement quality improvements This item indicates the need for or supplies changes that improve maintainability labels Jan 20, 2020
@guilhermelawless guilhermelawless added this to the V21.0 milestone Jan 20, 2020
@zhyatt zhyatt requested a review from SergiySW January 20, 2020 14:36
@SergiySW
Copy link
Contributor

Is informing reps of very-behind sequence numbers supposed to work only for crawler targets then?

@clemahieu
Copy link
Contributor Author

Yes, this is just to catch an actual rep up to speed. After the rep is updated they will continue to increase their sequence numbers as usual and everyone else will receive the new votes.

cryptocode
cryptocode previously approved these changes Jan 24, 2020
View reviewed changes
@guilhermelawless guilhermelawless self-requested a review January 24, 2020 09:21
@clemahieu clemahieu merged commit b2c094a into develop Jan 25, 2020
@guilhermelawless guilhermelawless deleted the vote_replay_in_crawler branch January 25, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@guilhermelawless guilhermelawless guilhermelawless approved these changes

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode left review comments

Assignees

@clemahieu clemahieu

Labels
performance Performance/resource utilization improvement quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@clemahieu @SergiySW @wezrule @guilhermelawless @cryptocode