Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rep crawler cleanup #2482

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Rep crawler cleanup #2482

merged 3 commits into from
Jan 20, 2020

Conversation

clemahieu
Copy link
Contributor

@clemahieu clemahieu commented Jan 14, 2020 •
edited
Loading

Move processing effort on to rep_crawler and off of the vote processor.

  • The response function has been converted to a lightweight function that simply queues votes to be checked on the next craw interval.
  • Logic around updating reps has been moved out of the callback lambda and into the rep processor itself.
  • The rep processor no longer accepts arbitrary values and directly computes weight from a given vote so tests have been updated accordingly.

@clemahieu clemahieu force-pushed the rep-crawler-cleanup branch from e248f49 to 31fe5e8 Compare January 18, 2020 18:16
@guilhermelawless guilhermelawless self-requested a review January 18, 2020 19:24
@guilhermelawless guilhermelawless added this to the V21.0 milestone Jan 18, 2020
wezrule
wezrule reviewed Jan 18, 2020
View reviewed changes
nano/core_test/node.cpp Outdated Show resolved Hide resolved
nano/node/repcrawler.cpp Show resolved Hide resolved
nano/node/repcrawler.hpp Outdated Show resolved Hide resolved
@clemahieu
Adding references to some parameter specifications, using emplace_bac…
c0faa4b 
…k, and fixing test to check for deadline errors.
cryptocode
cryptocode previously approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 31fe5e8 runs fine on livenet

@clemahieu
Adding references to some parameter specifications, using emplace_bac…
eb3236c 
…k, and fixing test to check for deadline errors.
@clemahieu clemahieu force-pushed the rep-crawler-cleanup branch from 49ac49e to eb3236c Compare January 20, 2020 01:07
cryptocode
cryptocode approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(failing win test is intermittent and unrelated, #1121 (comment))

@clemahieu clemahieu merged commit 0277414 into develop Jan 20, 2020
@guilhermelawless guilhermelawless deleted the rep-crawler-cleanup branch January 20, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule left review comments

@cryptocode cryptocode cryptocode approved these changes

@guilhermelawless guilhermelawless Awaiting requested review from guilhermelawless

Assignees

@clemahieu clemahieu

Labels
non-functional change
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@clemahieu @wezrule @cryptocode @zhyatt @guilhermelawless