Reduce memory used by callback data in confirmation height processor #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
approved these changes
Jan 1, 2020
clemahieu
approved these changes
Jan 3, 2020
SergiySW
approved these changes
Jan 9, 2020
|
No longer needed thanks to #2531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2233 made the confirmation height processor use a lot more memory as it stored the whole block & sideband for each block it traversed. This has been changed to only store the block hash. An additional
store.block_get ()is then required later to retrieve the contents but this didn't have any measurable performance hit from benchmarking and gave considerable memory reduction gains, as shown below:It shows for the
confirmation_height.long_chainstest in theslow_testsa reduction from 82MB to 12MB (86% less memory) for the affected containers. The memory is still unbounded (as well as forreceive_source_pairs) but it has been significantly reduced and a proper bounded solution is scheduled for a future release.I increased the number of blocks used in the slow_test.