Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seq_con_info
is not fully accurate, because there are many containers that are used not just sequence (vector, list etc..), such as maps. Changed it to becontainer_info
.I started a trend of using
namespace nano
guards around thecollect_seq_con_info
functions. We don't do this anywhere else (and I think that should stay the case). So adding the nano namespace qualifier to these functions i.enano::...
. Also arranged the contents of those functions to be more consistent with each other and removed any= 0
count initialises because they are always set later so it's redundant.config.hpp
No need for static, as
const
variables implicitly have static linakge already (of course you need the "pointer to constant data" form too:const char* const str
)core_test/rpc.cpp
The
rpc.database_txn_tracker
test was not being run when building with rocksdb regardless of the TEST_USE_ROCKSDB env variable, it should only be disabled if actually using it.Some tests were missing
ASSERT_NO_ERROR
aroundsystem.poll ()
and somesystem.deadline_set ()
calls before them too.core_test/locks.cpp
I had built with a ridiculously high
NANO_TIMED_LOCKS
value, without even realising, then noticed the locks tests appearing to stall. This is just because they do a sleep for theNANO_TIMED_LOCKS
length inside the test, so I'm now failing the test if it is greater than 10 seconds just so that they can finish at least.