Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove raw new operator used with smart pointers #2428

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Remove raw new operator used with smart pointers #2428

merged 1 commit into from
Dec 9, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Dec 6, 2019 •
edited
Loading

Use std::make_unique/std::make_shared where appropriate.

Also removed some duplication in nano::deserialize_block_json

@wezrule wezrule added this to the V21.0 milestone Dec 6, 2019
@wezrule wezrule requested a review from cryptocode December 6, 2019 10:22
@wezrule wezrule self-assigned this Dec 6, 2019
cryptocode
cryptocode approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wezrule wezrule merged commit 198b311 into nanocurrency:develop Dec 9, 2019
@wezrule wezrule deleted the remove_raw_new_operator branch December 9, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@wezrule wezrule

Labels
non-functional change
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wezrule @cryptocode