Set wallet representative with RPC receive on unopened accounts #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
bug
documentation
cryptocode
reviewed
Nov 28, 2019
cryptocode
approved these changes
Nov 28, 2019
argakiig
approved these changes
Nov 29, 2019
guilhermelawless
added a commit
to guilhermelawless/nano-node
that referenced
this pull request
Dec 4, 2019
Changes from nanocurrency#2388 were not factored into nanocurrency#2419 since there were new RPC tests
Merged
guilhermelawless
added a commit
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2418
Will update documentation, should state that the wallet representative will be used from V21, and the own account is used in V20 and before, for unopened accounts.
Adds a suite of tests for RPC receive.