Disable vote rebroadcasting while cemented count is below hardcoded bootstrap block count #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otstrap block count
guilhermelawless
added
performance
cryptocode
previously approved these changes
Dec 7, 2019
SergiySW
approved these changes
Feb 19, 2020
cryptocode
approved these changes
Feb 19, 2020
|
We are planning to hold off on merging this for now in favor of looking into limiting rebroadcasting of votes from confirm_req more generally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2410 . It's a heuristic since blocks that don't go towards the bootstrap block count can be cemented, but close enough. Other heuristics can follow in the future to understand the likelihood of a vote being useful to the network.
One thing to take into account is nodes with disabled frontier confirmation ( #2175 ); it's likely they also reach this cemented count through the confirmation height processor trickling down through millions of blocks. Disabling vote rebroadcasting completely for these nodes would be another option.