Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSAN] Data race in active_difficulty.recalculate_work test #2393

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[TSAN] Data race in active_difficulty.recalculate_work test #2393

merged 1 commit into from
Nov 6, 2019

Conversation

guilhermelawless
Copy link
Contributor

This failure was tied to a data race on active_transactions::multipliers_cb.

[ RUN      ] active_difficulty.recalculate_work
/Users/travis/build/guilhermelawless/nano-node/nano/core_test/node.cpp:3208: Failure
Expected equality of these values:
  node1.active.active_difficulty ()
    Which is: 18414790985620493964
  nano::difficulty::from_multiplier (sum / node1.active.multipliers_cb.size (), node1.network_params.network.publish_threshold)
    Which is: 18415888479324436004
[  FAILED  ] active_difficulty.recalculate_work (182 ms)

@guilhermelawless guilhermelawless added the unit test Related to a new, changed or fixed unit test label Nov 6, 2019
@guilhermelawless guilhermelawless added this to the V20.0 milestone Nov 6, 2019
@guilhermelawless guilhermelawless self-assigned this Nov 6, 2019
@guilhermelawless guilhermelawless changed the title [ASAN] Data race in active_difficulty.recalculate_work test [TSAN] Data race in active_difficulty.recalculate_work test Nov 6, 2019
@guilhermelawless guilhermelawless force-pushed the test/active-difficulty-asan branch from 967a476 to 2614879 Compare November 6, 2019 09:18
@guilhermelawless guilhermelawless merged commit 9f1afb1 into nanocurrency:master Nov 6, 2019
@guilhermelawless guilhermelawless deleted the test/active-difficulty-asan branch November 6, 2019 11:36
argakiig pushed a commit that referenced this pull request Nov 8, 2019
@guilhermelawless
[TSAN] Data race in active_difficulty.recalculate_work test (#2393)
ad8360b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@guilhermelawless @wezrule