Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC block_create fixes #2380

Merged
merged 1 commit into from
Nov 1, 2019
Merged

RPC block_create fixes #2380

merged 1 commit into from
Nov 1, 2019

Conversation

cryptocode
Copy link
Contributor

Two fixes discovered from rpc_test runs:

  1. Asserts in Debug builds because work is set after building blocks (now using error_code, an alternative is setting 0 work temporarily, but I liked this solution better)
  2. A timer assert, which pointed to responses being sent twice on success - first via block_response_put_l and then via response_errors.

@cryptocode cryptocode self-assigned this Nov 1, 2019
@cryptocode cryptocode added the bug label Nov 1, 2019
@cryptocode cryptocode added this to the V20.0 milestone Nov 1, 2019
guilhermelawless
guilhermelawless approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

std::unique_ptr<_Tp> nano::abstract_builder<BLOCKTYPE, BUILDER>::build() [with BLOCKTYPE = nano::send_block; BUILDER = nano::send_block_builder]: Assertion `!ec' failed.

No issues with this fix, thanks!

@cryptocode cryptocode merged commit 07ce097 into nanocurrency:master Nov 1, 2019
@cryptocode cryptocode deleted the block_create_fixes branch November 1, 2019 19:33
argakiig pushed a commit that referenced this pull request Nov 8, 2019
@cryptocode
RPC block_create fixes (#2380)
c00e72a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermelawless guilhermelawless guilhermelawless approved these changes

Assignees

@cryptocode cryptocode

Labels
bug
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptocode @guilhermelawless