-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart dropped elections for unconfirmed blocks with higher PoW #2335
Restart dropped elections for unconfirmed blocks with higher PoW #2335
Conversation
Marked as incomplete, will add a cache of recently dropped elections to reduce DB I/O in this path. |
Finished, up to 32k dropped elections (less than 100 bytes each, 3MB) and only considered for checking the DB if the upgraded PoW arrived within 60 seconds (can increase this value). |
…ss/nano-node into restart-dropped-elections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor refactoring suggestion
With this and #2306 prioritization should be fully guaranteed.
Requires:
A 60s buffer of dropped elections is added which sets the maximum time another node has to send the upgraded block before it will only be confirmed via frontier confirmation. This was added to prevent high DB usage for any old block, instead it is only done if the root has been recently dropped. This grants protection from bad actors as they do not know which elections we dropped.
However:
Therefore, another approach will follow in the future using a large container of passive elections.